Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line that was missed when dropping Py3.7 support #1297

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

javulticat
Copy link
Member

Description

A single (but rather important) line was missed in #1292, which, if not corrected, may allow package managers to install any new releases of Zappa on Py3.7, even though all logic needed to support Py3.7 has now been removed from Zappa.

This PR is a 1-line (1-char, to be precise 🙃) fix which must be merged before any new release of Zappa can be published.

@javulticat javulticat added the needs-review Needs attention from a maintainer label Jan 14, 2024
@javulticat javulticat requested review from hellno and monkut January 14, 2024 00:51
@javulticat javulticat self-assigned this Jan 14, 2024
@coveralls
Copy link

Coverage Status

coverage: 74.831%. remained the same
when pulling 58f6cbe on jav/py3.12
into 77689e2 on master.

@javulticat javulticat added bug Something isn't working easy-fix priority | P1 Priority: High labels Jan 14, 2024
@monkut monkut merged commit 57d2672 into master Jan 19, 2024
6 checks passed
@monkut monkut deleted the jav/py3.12 branch January 19, 2024 00:05
@javulticat javulticat removed needs-review Needs attention from a maintainer priority | P1 Priority: High labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants